-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(form-field): implement hover state #9215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/lib/form-field/form-field.scss
Outdated
@@ -195,6 +195,19 @@ $mat-form-field-default-infix-width: 180px !default; | |||
} | |||
} | |||
|
|||
// Note that we need this specific of a selector because we don't want | |||
// want the hover effect to show when the user hovers over the hints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crisbeto duplicate word 'want' on new line
ba97a58
to
f49d605
Compare
This feels a little jarring currently, I think it needs some animation to make it feel smoother. The animation videos in the spec don't seem to agree with the static images, since they show the underline already thick before hovering, so we might just have to play around with it on our own |
f49d605
to
61c41ee
Compare
Added a short transition @mmalerba. |
while you're at it, it looks like error state should be 2px underline as well |
[Based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states) form fields should have a hover state where the underline gets darkened while the user is hovering and gets replaced by the theme color after the focus the input.
61c41ee
to
50af637
Compare
FYI, I've rolled these changes into the |
Closing in favor of #9366. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Based on the spec form fields should have a hover state where the underline gets darkened while the user is hovering and gets replaced by the theme color after the focus the input.