fix(chips): add bottom margin for all the chips #9224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tinayuangao
added
pr: needs review
target: patch
jelbourn
reviewed
Jan 11, 2018
|
|
||
| [dir='rtl'] & { | ||
| margin: 0 $mat-chips-chip-margin 0 0; | ||
| margin: 0 $mat-chips-chip-margin $mat-chip-input-margin 0; |
There was a problem hiding this comment.
I suspect that this is something that we'd need to wait for a major version to change, since it could affect layouts in existing apps. It would also affect chips that aren't in a chip-list (which really shouldn't have any margin whatsoever).
|
Close this pr since #9762 is in. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8587