Skip to content

docs(list): expand accessibility section #9443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2018
Merged

docs(list): expand accessibility section #9443

merged 1 commit into from
Jan 18, 2018

Conversation

jelbourn
Copy link
Member

No description provided.

@jelbourn jelbourn added pr: needs review Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation labels Jan 17, 2018
@jelbourn jelbourn requested a review from tinayuangao January 17, 2018 18:37
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 17, 2018
crisbeto
crisbeto approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib/list/list.md Outdated
@@ -152,8 +152,24 @@ To add a divider, use `<mat-divider>`.
```

### Accessibility
The type of list used in any given situation depends on how the end-user will be interacting with
the list.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...interacting with it", you already mentioned "list" earlier.

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Jan 18, 2018
@josephperrott josephperrott merged commit 5c87a84 into angular:master Jan 18, 2018
@jelbourn jelbourn deleted the list-ally-docs branch April 2, 2018 22:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jelbourn @crisbeto @googlebot @josephperrott