fix(button): no color set for flat and icon buttons #9536
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tinayuangao
approved these changes
Jan 24, 2018
| <p> | ||
| <mat-toolbar> | ||
| <mat-icon class="demo-toolbar-icon">menu</mat-icon> | ||
| <span>Default Toolbar</span> | ||
| <button mat-icon-button> |
There was a problem hiding this comment.
nit: do we want to keep one mat-icon without button in the demo?
There was a problem hiding this comment.
Good point. I have such plain <mat-icon> elements in the demo toolbars below.
jelbourn
reviewed
Jan 24, 2018
src/lib/button/button.scss
Outdated
| .mat-button-wrapper > * { | ||
| vertical-align: middle; | ||
| } | ||
| } | ||
|
|
||
| // Buttons that don't have a background color can inherit the color from its parent. | ||
| .mat-button, .mat-icon-button { | ||
| color: inherit; |
There was a problem hiding this comment.
inherit or currentColor? Is inherit supported on IE11?
There was a problem hiding this comment.
Yeah, just confirmed that inherited is supported.
devversion
added
in progress
* Currently for flat buttons and icon buttons, the font color is not set by the theme. This can cause the text to be invisible on those buttons in a dark theme. From now on, those buttons will also receive a font color by the theme. * Flat buttons and icon buttons inside of a `<mat-toolbar>` will inherit the font color from the toolbar row. This ensures that those buttons are looking as expected in themed toolbars (e.g. primary, accent, warn) Fixes angular#4614. Fixes angular#9231. Fixes angular#9634
devversion
force-pushed
the
fix/buttons-font-color-overwritten
branch
from
05ba139 to
0806b29
Compare
devversion
added
pr: needs review
and removed
in progress
devversion
changed the title
|
@crisbeto Updated to what we discussed. Please have a look. |
devversion
added
the
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<mat-toolbar>will inherit the font color from the toolbar row. This ensures that those buttons are looking as expected in themed toolbars (e.g. primary, accent, warn)Fixes #4614. Fixes #9231. Fixes #9634