Skip to content

refactor(chips): use key manager for horizontal keyboard controls #9600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

crisbeto
Copy link
Member

Switches to using the horizontal mode from the ListKeyManager for the left/right controls, rather than reimplementing them.

@crisbeto crisbeto requested a review from tinayuangao as a code owner January 25, 2018 15:39
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 25, 2018
Switches to using the horizontal mode from the `ListKeyManager` for the left/right controls, rather than reimplementing them.
@crisbeto crisbeto force-pushed the chip-list-horizontal-key-manager branch from 3b47546 to 239909e Compare January 25, 2018 15:40
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Jan 25, 2018
@jelbourn jelbourn merged commit 5a055a7 into angular:master Jan 26, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants