This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(panel): allow numbers in offset methods #9609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErinCoughlan
approved these changes
Sep 14, 2016
|
|
||
| /** | ||
| * Adds units to a number value. | ||
| * @param {number} value |
There was a problem hiding this comment.
@param {string | number} value
crisbeto
force-pushed
the
9604/panel-units
branch
2 times, most recently
from
628ec9f to
ae7a0d3
Compare
crisbeto
added
the
needs: rebase
crisbeto
force-pushed
the
9604/panel-units
branch
from
ae7a0d3 to
b894397
Compare
crisbeto
removed
the
needs: rebase
3 tasks
crisbeto
added
the
needs: rebase
crisbeto
force-pushed
the
9604/panel-units
branch
from
b894397 to
07a594c
Compare
crisbeto
removed
the
needs: rebase
|
@ThomasBurleson this should be ready for presubmit. |
crisbeto
force-pushed
the
9604/panel-units
branch
from
07a594c to
cfd857e
Compare
Allows for numbers to be pass to the `withOffsetX` and `withOffsetY` methods, assuming that the units are pixels. Fixes angular#9604.
crisbeto
force-pushed
the
9604/panel-units
branch
from
cfd857e to
abeeb87
Compare
Splaktar
added
P3: important
chmelevskij
pushed a commit
to chmelevskij/material
that referenced
this pull request
Jun 19, 2018
Allows for numbers to be pass to the `withOffsetX` and `withOffsetY` methods, assuming that the units are pixels. Fixes angular#9604.
Splaktar
pushed a commit
that referenced
this pull request
Jul 31, 2018
Allows for numbers to be pass to the `withOffsetX` and `withOffsetY` methods, assuming that the units are pixels. Fixes #9604.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for numbers to be pass to the
withOffsetXandwithOffsetYmethods, assuming that the units are pixels.Fixes #9604.
CC @ErinCoughlan @bradrich