This repository was archived by the owner on May 22, 2025. It is now read-only.
This commit updates tsickle's JSDoc closure translation to #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
not attempt translating/resolving enum members multiple times. The double lookup was introduced back then with the TS 5.x bump. This is important because in complex applications, this may be extremely expensive, causing double expensive lookups searching all files and their exports in a `ts.Program`. PiperOrigin-RevId: 626365165
copybara-service
bot
force-pushed
the
test_626365165
branch
from
3333a5b to
efeee83
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates tsickle's JSDoc closure translation to
not attempt translating/resolving enum members multiple times.
The double lookup was introduced back then with the TS 5.x bump.
This is important because in complex applications, this may be
extremely expensive, causing double expensive lookups searching all files and their exports in a
ts.Program.