Skip to content

Add missing mappings from register classes to dummy output types #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

zedar
Copy link

@zedar zedar commented Mar 24, 2024

No description provided.

@zedar zedar force-pushed the I60_asm_conversion_from_register_to_gcc branch from 462a562 to 3508273 Compare March 24, 2024 12:57
Copy link
Owner

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, but the rest is good.
Thanks!

src/asm.rs Outdated
InlineAsmRegClass::CSKY(CSKYInlineAsmRegClass::reg) => cx.type_i32(),
InlineAsmRegClass::CSKY(CSKYInlineAsmRegClass::freg) => cx.type_f32(),
InlineAsmRegClass::SpirV(SpirVInlineAsmRegClass::reg) => {
bug!("LLVM backend does not support SPIR-V")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bug!("LLVM backend does not support SPIR-V")
bug!("GCC backend does not support SPIR-V")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@zedar zedar force-pushed the I60_asm_conversion_from_register_to_gcc branch from 3508273 to 94ca828 Compare March 24, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants