HADOOP-19416. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-kms. #7637

slfan1989 · 2025-04-20T01:43:38Z

Description of PR

JIRA: HADOOP-19416. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-kms.

How was this patch tested?

Junit test & mvn clean test.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2025-04-20T05:26:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	20m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 7 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 32s		trunk passed
+1 💚	compile	17m 25s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	15m 11s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 40s		trunk passed
+1 💚	mvnsite	0m 45s		trunk passed
+1 💚	javadoc	0m 45s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 39s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 58s		trunk passed
+1 💚	shadedclient	39m 36s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 19s		the patch passed
+1 💚	compile	16m 37s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	16m 37s		the patch passed
+1 💚	compile	14m 56s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	14m 56s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	0m 37s	/results-checkstyle-hadoop-common-project_hadoop-kms.txt	hadoop-common-project/hadoop-kms: The patch generated 62 new + 51 unchanged - 2 fixed = 113 total (was 53)
+1 💚	mvnsite	0m 42s		the patch passed
+1 💚	javadoc	0m 41s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 37s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	1m 4s		the patch passed
+1 💚	shadedclient	38m 56s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	3m 53s		hadoop-kms in the patch passed.
+1 💚	asflicense	1m 3s		The patch does not generate ASF License warnings.
		222m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7637/1/artifact/out/Dockerfile
GITHUB PR	#7637
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux f6f787f03da9 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `e2095ed`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7637/1/testReport/
Max. process+thread count	530 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7637/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

jojochuang

Looks good. Just a minor checkstyle

jojochuang · 2025-04-20T03:32:42Z

...s/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKeyAuthorizationKeyProvider.java

  public void testDecryptWithKeyVersionNameKeyMismatch() throws Exception {
-    final Configuration conf = new Configuration();
-    KeyProvider kp =
+      Assertions.assertThrows(IllegalArgumentException.class, () -> {


indentation.

Suggested change

Assertions.assertThrows(IllegalArgumentException.class, () -> {

Assertions.assertThrows(IllegalArgumentException.class, () -> {

Thank you very much for reviewing the code! I have fixed the checkstyle issue.

hadoop-yetus · 2025-04-21T07:22:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 7 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 17s		trunk passed
+1 💚	compile	17m 28s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	15m 9s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 39s		trunk passed
+1 💚	mvnsite	0m 44s		trunk passed
+1 💚	javadoc	0m 44s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 37s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 57s		trunk passed
+1 💚	shadedclient	39m 17s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 19s		the patch passed
+1 💚	compile	16m 39s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	16m 39s		the patch passed
+1 💚	compile	14m 47s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	14m 47s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 35s	/results-checkstyle-hadoop-common-project_hadoop-kms.txt	hadoop-common-project/hadoop-kms: The patch generated 54 new + 51 unchanged - 2 fixed = 105 total (was 53)
+1 💚	mvnsite	0m 42s		the patch passed
+1 💚	javadoc	0m 41s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 39s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	1m 2s		the patch passed
+1 💚	shadedclient	39m 12s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	3m 53s		hadoop-kms in the patch passed.
+1 💚	asflicense	1m 2s		The patch does not generate ASF License warnings.
		201m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7637/2/artifact/out/Dockerfile
GITHUB PR	#7637
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 5599e10fa120 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `d7ad1f7`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7637/2/testReport/
Max. process+thread count	590 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7637/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-04-21T15:53:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 1s		The patch appears to include 7 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 2s		trunk passed
+1 💚	compile	17m 18s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	14m 56s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 40s		trunk passed
+1 💚	mvnsite	0m 43s		trunk passed
+1 💚	javadoc	0m 44s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 39s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 57s		trunk passed
+1 💚	shadedclient	40m 16s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 19s		the patch passed
+1 💚	compile	20m 26s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	20m 26s		the patch passed
+1 💚	compile	15m 57s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	15m 57s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 33s	/results-checkstyle-hadoop-common-project_hadoop-kms.txt	hadoop-common-project/hadoop-kms: The patch generated 19 new + 51 unchanged - 2 fixed = 70 total (was 53)
+1 💚	mvnsite	0m 38s		the patch passed
+1 💚	javadoc	0m 41s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 38s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	1m 4s		the patch passed
+1 💚	shadedclient	39m 3s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	3m 54s		hadoop-kms in the patch passed.
+1 💚	asflicense	1m 1s		The patch does not generate ASF License warnings.
		205m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7637/3/artifact/out/Dockerfile
GITHUB PR	#7637
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 92f7871c3981 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `31f4a55`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7637/3/testReport/
Max. process+thread count	524 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7637/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-04-23T00:20:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 7 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 34s		trunk passed
+1 💚	compile	17m 18s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	14m 48s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 39s		trunk passed
+1 💚	mvnsite	0m 43s		trunk passed
+1 💚	javadoc	0m 45s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 38s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 57s		trunk passed
+1 💚	shadedclient	38m 49s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 19s		the patch passed
+1 💚	compile	16m 41s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	16m 41s		the patch passed
+1 💚	compile	14m 49s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	14m 49s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 34s	/results-checkstyle-hadoop-common-project_hadoop-kms.txt	hadoop-common-project/hadoop-kms: The patch generated 1 new + 29 unchanged - 24 fixed = 30 total (was 53)
+1 💚	mvnsite	0m 41s		the patch passed
+1 💚	javadoc	0m 41s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 38s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	1m 2s		the patch passed
+1 💚	shadedclient	39m 3s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	3m 55s		hadoop-kms in the patch passed.
+1 💚	asflicense	1m 2s		The patch does not generate ASF License warnings.
		201m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7637/4/artifact/out/Dockerfile
GITHUB PR	#7637
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux cddb67a8e62f 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `4f6d91c`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7637/4/testReport/
Max. process+thread count	575 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7637/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

jojochuang

+1

jojochuang · 2025-04-23T04:34:16Z

Merged. Thanks @slfan1989 !

slfan1989 · 2025-04-23T15:21:01Z

@jojochuang Thank you very much for the review!

HADOOP-19416. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-kms.

e2095ed

github-actions bot added trunk Common labels Apr 20, 2025

jojochuang reviewed Apr 20, 2025

View reviewed changes

HADOOP-19416. Fix CheckStyle Issue.

d7ad1f7

slfan1989 marked this pull request as ready for review April 21, 2025 04:20

HADOOP-19416. Fix CheckStyle.

31f4a55

slfan1989 requested a review from jojochuang April 22, 2025 20:49

HADOOP-19416. Fix CheckStyle.

4f6d91c

jojochuang approved these changes Apr 23, 2025

View reviewed changes

jojochuang merged commit 08f4068 into apache:trunk Apr 23, 2025
4 checks passed

slfan1989 mentioned this pull request Apr 25, 2025

[DISCUSS] [JDK17] Upgrade JUnit / JavaDoc from 4 to 5. #7337

Draft

74 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-19416. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-kms. #7637

HADOOP-19416. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-kms. #7637

slfan1989 commented Apr 20, 2025 •

edited

Loading

hadoop-yetus commented Apr 20, 2025

jojochuang left a comment

jojochuang Apr 20, 2025

slfan1989 Apr 21, 2025

hadoop-yetus commented Apr 21, 2025

hadoop-yetus commented Apr 21, 2025

hadoop-yetus commented Apr 23, 2025

jojochuang left a comment

jojochuang commented Apr 23, 2025

slfan1989 commented Apr 23, 2025

	Assertions.assertThrows(IllegalArgumentException.class, () -> {
	Assertions.assertThrows(IllegalArgumentException.class, () -> {

HADOOP-19416. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-kms. #7637

HADOOP-19416. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-kms. #7637

Conversation

slfan1989 commented Apr 20, 2025 • edited Loading

Description of PR

How was this patch tested?

For code changes:

hadoop-yetus commented Apr 20, 2025

jojochuang left a comment

Choose a reason for hiding this comment

jojochuang Apr 20, 2025

Choose a reason for hiding this comment

slfan1989 Apr 21, 2025

Choose a reason for hiding this comment

hadoop-yetus commented Apr 21, 2025

hadoop-yetus commented Apr 21, 2025

hadoop-yetus commented Apr 23, 2025

jojochuang left a comment

Choose a reason for hiding this comment

jojochuang commented Apr 23, 2025

slfan1989 commented Apr 23, 2025

slfan1989 commented Apr 20, 2025 •

edited

Loading