-
Notifications
You must be signed in to change notification settings - Fork 9k
HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part4. #7647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
3b74067
to
5eb8500
Compare
🎊 +1 overall
This message was automatically generated. |
5eb8500
to
58f1902
Compare
🎊 +1 overall
This message was automatically generated. |
@@ -28,11 +28,10 @@ public class TestAdminHelper { | |||
@Test | |||
public void prettifyExceptionWithNpe() { | |||
String pretty = AdminHelper.prettifyException(new NullPointerException()); | |||
Assert.assertTrue( | |||
Assertions.assertTrue(pretty.startsWith("NullPointerException at org.apache.hadoop.hdfs.tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to use static import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! I'll update the code as soon as possible.
58f1902
to
5558aa1
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
28e9b0a
to
f0a1ec1
Compare
f0a1ec1
to
5fe19e5
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
5fe19e5
to
9b71eb0
Compare
💔 -1 overall
This message was automatically generated. |
Description of PR
JIRA:HDFS-12431. Upgrade JUnit from 4 to 5 in hadoop-hdfs Part4.
How was this patch tested?
Junit Test.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?