-
Notifications
You must be signed in to change notification settings - Fork 941
[KYUUBI #7028] Persist the kubernetes application terminate state into metastore for app info store fallback #7029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d167623
migration
turboFei becf9d1
insert or replace
turboFei 12c24b1
do not use MYSQL deprecated VALUES(col)
turboFei 327a0d5
Remove create_time from k8s engine info
turboFei 4c59beb
Refine
turboFei 82ea626
Add pod name
turboFei 186cc69
nit
turboFei 9f2bade
generic dialect
turboFei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,11 @@ package org.apache.kyuubi.server.metadata.jdbc | |
|
||
trait JdbcDatabaseDialect { | ||
def limitClause(limit: Int, offset: Int): String | ||
def insertOrReplace( | ||
table: String, | ||
colsToInsert: Seq[String], | ||
colsToReplace: Seq[String], | ||
keyCol: String): Option[String] = None | ||
} | ||
|
||
class GenericDatabaseDialect extends JdbcDatabaseDialect { | ||
|
@@ -27,6 +32,47 @@ class GenericDatabaseDialect extends JdbcDatabaseDialect { | |
} | ||
} | ||
|
||
class SQLiteDatabaseDialect extends GenericDatabaseDialect {} | ||
class MySQLDatabaseDialect extends GenericDatabaseDialect {} | ||
class PostgreSQLDatabaseDialect extends GenericDatabaseDialect {} | ||
class SQLiteDatabaseDialect extends GenericDatabaseDialect { | ||
override def insertOrReplace( | ||
table: String, | ||
colsToInsert: Seq[String], | ||
colsToReplace: Seq[String], | ||
keyCol: String): Option[String] = { | ||
Some( | ||
s""" | ||
|INSERT OR REPLACE INTO $table (${colsToInsert.mkString(",")}) | ||
|VALUES (${colsToInsert.map(_ => "?").mkString(",")}) | ||
|""".stripMargin) | ||
} | ||
} | ||
class MySQLDatabaseDialect extends GenericDatabaseDialect { | ||
override def insertOrReplace( | ||
table: String, | ||
colsToInsert: Seq[String], | ||
colsToReplace: Seq[String], | ||
keyCol: String): Option[String] = { | ||
Some( | ||
s""" | ||
|INSERT INTO $table (${colsToInsert.mkString(",")}) | ||
|VALUES (${colsToInsert.map(_ => "?").mkString(",")}) | ||
|ON DUPLICATE KEY UPDATE | ||
|${colsToReplace.map(c => s"$c = VALUES($c)").mkString(",")} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|""".stripMargin) | ||
} | ||
} | ||
class PostgreSQLDatabaseDialect extends GenericDatabaseDialect { | ||
override def insertOrReplace( | ||
table: String, | ||
colsToInsert: Seq[String], | ||
colsToReplace: Seq[String], | ||
keyCol: String): Option[String] = { | ||
Some( | ||
s""" | ||
|INSERT INTO $table (${colsToInsert.mkString(",")}) | ||
|VALUES (${colsToInsert.map(_ => "?").mkString(",")}) | ||
|ON CONFLICT ($keyCol) | ||
|DO UPDATE SET | ||
|${colsToReplace.map(c => s"$c = EXCLUDED.$c").mkString(",")} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|""".stripMargin) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.