Skip to content

Port date & time formatter rewrite to main #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2024
Merged

Port date & time formatter rewrite to main #3150

merged 3 commits into from
Nov 7, 2024

Conversation

vy
Copy link
Member

@vy vy commented Oct 31, 2024

Ports #3121 to main.

@vy vy added performance Issues or PRs that affect performance, throughput, latency, etc. layouts Affects one or more Layout plugins labels Oct 31, 2024
@vy vy added this to the 3.x milestone Oct 31, 2024
@vy vy requested a review from ppkarwasz October 31, 2024 15:20
@vy vy self-assigned this Oct 31, 2024
@vy vy changed the base branch from 2.x to main October 31, 2024 15:20
@vy vy mentioned this pull request Nov 2, 2024
Closed
ppkarwasz
ppkarwasz approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In the future we might expose some time formatting API in log4j-kit, but that would not require breaking changes.

@vy vy merged commit 025b4bd into main Nov 7, 2024
9 checks passed
@vy vy deleted the feature/main/instant-formatter branch November 7, 2024 12:58
@ppkarwasz
Copy link
Contributor

Fixes #1416.

@ppkarwasz ppkarwasz mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppkarwasz ppkarwasz ppkarwasz approved these changes

Assignees

@vy vy

Labels
layouts Affects one or more Layout plugins performance Issues or PRs that affect performance, throughput, latency, etc.
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@vy @ppkarwasz