[MDEPLOY-206] Support parallel deploy at end #5
Conversation
| getLog().info( "Submitting " + projectDeployerRequest.getProject().getName() ); | ||
| service.submit( callable ); | ||
| } | ||
| else |
There was a problem hiding this comment.
The else could be avoided by using an executor with just a single worker thread.
There was a problem hiding this comment.
I did this to maintain passivity by leaving the upload on the current thread.
There was a problem hiding this comment.
You could do that by using a ExecutionService which runs the workers in the same thread like the DirectExecutor from https://google.github.io/guava/releases/24.0-jre/api/docs/index.html?com/google/common/util/concurrent/MoreExecutors.html
There was a problem hiding this comment.
please no dependency on guava....
There was a problem hiding this comment.
I'd create a similar service in Maven's support libraries. Being able to switch freely between parallel and serial execution with the same code is probably useful elsewhere (like running unit tests or reports).
|
@mattnelson thanks for your effort on resolving issue. Suppressed by #35 |
|
Resolve #480 |
https://issues.apache.org/jira/browse/MDEPLOY-206
Support parallel deploy at end.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MPH-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MPH-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.