-
Notifications
You must be signed in to change notification settings - Fork 134
[MRESOLVER-32] Parallel deploy and more #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Applied very same logic that download has, uses same pool as well. --- https://issues.apache.org/jira/browse/MRESOLVER-32
…on for default value.
As thread pool may left dangling in some cases
Every new feature should remain dormant unless said so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the introduction of ThreadsUtils to a separate PR. Also the change from int to String might lead to missed input stream the config utils request an int, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should provide separate PR with separate issue for each new feature.
As you mention in description I see new features or improvements like:
- dynamic
core count
- BF collector enhanced
- PUTs in parallel
Ok, will do it, but sequentially, as I don't see how to create these 3 PRs simultaneously without conflicts against each other, and I would not like to spend time on fixing conflicts after each merge, just for "purity". So, please then, be prepared for snappy reviews 😉 In other words, having these 3 commits separate is okay, but will not allow their initial purpose (for example to roll back one of them) as all 3 are quite interleaving with each other. |
Layered, sequentically, of course. Not in parallel. |
Why make parallel put an option? I mean if we do parallel downloads by default, why not do the same with uploads? Do you see a risk here? |
Closing this one out, this PR was split in 3: |
General improvements regarding threads and thread pool use in code, leaving all the functionality untouched (same things are done, just centralized), while basic connector is the only modified one, that is now able to perform parallel upload as well.
Changes:
-T
parsing)In action: https://asciinema.org/a/fBTcOTSJF0cRmHsr8hZuIQrpw
(note: local repo contained m-deploy-p 3.1.0-SNAPSHOT installed, needed to fully utilize deployAtEnd apache/maven-deploy-plugin#38)
https://issues.apache.org/jira/browse/MRESOLVER-32