-
Notifications
You must be signed in to change notification settings - Fork 4
[SPARK-51943] Upgrade setup-swift
to 3.0
dev version
#94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
next
tag
next
tagnext
tag
next
tagnext
tag
next
tagsetup-swift
to next
tag
Could you review this GitHub Action infra PR when you have some time, @yaooqinn ? |
.github/workflows/build_and_test.yml
Outdated
@@ -79,7 +79,7 @@ jobs: | |||
options: --entrypoint /opt/spark/sbin/start-connect-server.sh | |||
steps: | |||
- uses: actions/checkout@v4 | |||
- uses: swift-actions/setup-swift@v2.3.0 | |||
- uses: swift-actions/setup-swift@next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we replace this with the hash to satisfy ASF GitHub Actions Policy
External actions
You MAY use all actions internal to the apache/, github/ and actions/* namespaces without restrictions.
You MUST pin all external actions to the specific git hash (SHA1) of the action that has been reviewed for use by the project. For instance, you MUST pin foobar/baz-action@8843d7f92416211de9ebb963ff4ce28125932878.
BTW, we don't use hash yet in Apache Spark repo, do we?
In |
Hi @dongjoon-hyun, |
setup-swift
to next
tagsetup-swift
to 3.0
dev version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
Thank you! Merged to main. I'll keep tracking the upstream and update the githash time to time until the official 3.0 comes out. |
What changes were proposed in this pull request?
This PR aims to upgrade
setup-swift
tonext
tag in order to testsetup-swift 3.0
dev version.Why are the changes needed?
To fix the flakiness issues during
Swift
installation on linux environment.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.