Skip to content

[SPARK-51943] Upgrade setup-swift to 3.0 dev version #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Apr 29, 2025

What changes were proposed in this pull request?

This PR aims to upgrade setup-swift to next tag in order to test setup-swift 3.0 dev version.

Why are the changes needed?

To fix the flakiness issues during Swift installation on linux environment.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun changed the title Upgrade setup-swift to next tag Upgrade setup-swift to next tag Apr 29, 2025
@dongjoon-hyun dongjoon-hyun changed the title Upgrade setup-swift to next tag SPARK-51943: Upgrade setup-swift to next tag Apr 29, 2025
@dongjoon-hyun dongjoon-hyun changed the title SPARK-51943: Upgrade setup-swift to next tag [SPARK-51943] Upgrade setup-swift to next tag Apr 29, 2025
@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review April 29, 2025 04:45
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-51943] Upgrade setup-swift to next tag [SPARK-51943] Upgrade setup-swift to next tag Apr 29, 2025
@dongjoon-hyun
Copy link
Member Author

Could you review this GitHub Action infra PR when you have some time, @yaooqinn ?

@@ -79,7 +79,7 @@ jobs:
options: --entrypoint /opt/spark/sbin/start-connect-server.sh
steps:
- uses: actions/checkout@v4
- uses: swift-actions/setup-swift@v2.3.0
- uses: swift-actions/setup-swift@next
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we replace this with the hash to satisfy ASF GitHub Actions Policy

External actions
You MAY use all actions internal to the apache/, github/ and actions/* namespaces without restrictions.

You MUST pin all external actions to the specific git hash (SHA1) of the action that has been reviewed for use by the project. For instance, you MUST pin foobar/baz-action@8843d7f92416211de9ebb963ff4ce28125932878.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya and @yaooqinn .

Let me try to use hash.

@dongjoon-hyun
Copy link
Member Author

BTW, we don't use hash yet in Apache Spark repo, do we?

$ git grep setup-java | head -n1
.github/workflows/benchmark.yml:        uses: actions/setup-java@v4

In setup-java, v4 is just an alias for specific versions like v4.7.1

@yaooqinn
Copy link
Member

Hi @dongjoon-hyun, apache/, github/ and actions/* prefixed ones can be used w/o restrictions

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-51943] Upgrade setup-swift to next tag [SPARK-51943] Upgrade setup-swift to 3.0 dev version Apr 29, 2025
Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you! Merged to main.

I'll keep tracking the upstream and update the githash time to time until the official 3.0 comes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants