docs: Add information about how to significantly improve the test suite #1472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, this iPR adds an inromation for the page about `JWT` authentication about how to make the tests fast. The issue boils down to the very slow password hashers that are used in tests by default. Each time we start a new project, or review the current one, we have to do it, because tests are extremely slow. This is only one of the many optimizations available for the end developer, but let's start here. Other ones are listed in by blog post: https://maks-rafalko.github.io/blog/2021-11-21/symfony-tests-performance/#using-more-simple-password-hasher
dunglas
approved these changes
Nov 22, 2021
alanpoulain
reviewed
Nov 22, 2021
Exactly, already made an RFC there symfony/recipes#1024 |
Co-authored-by: Alan Poulain <[email protected]>
|
Thanks @maks-rafalko ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR adds an information for the page about
JWTauthentication about how to make the tests fast.The issue boils down to the very slow password hashers that are used in tests by default.
Each time we start a new project, or make a review of the existing one, we have to do it, because tests are extremely slow.
This is only one of the many optimizations available for the end developer, but let's start here. Other ones are listed in my blog post: https://maks-rafalko.github.io/blog/2021-11-21/symfony-tests-performance/#using-more-simple-password-hasher
In our cases, such change can improve tests speed by 2-5 times, depending on the project.