-
Notifications
You must be signed in to change notification settings - Fork 168
Moves XCTestCase.validate
into its own module
#135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves XCTestCase.validate
into its own module
#135
Conversation
XCTestCase.validate
into it’s own moduleXCTestCase.validate
into its own module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great, I presume that it works fine for importing to other project testing on both Darwin and Linux?
@@ -12,6 +12,7 @@ | |||
import XCTest | |||
import AsyncAlgorithms | |||
import AsyncSequenceValidation | |||
@testable import AsyncAlgorithms_XCTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this prevents us from doing release-mode testing of perf. I am of the belief that this DEFINITELY should be tested, but we kinda need to settle on a way to do this AND accommodate for testing performance too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually didn't realize that this prevents that. I thought about moving the tests to their own test target for the new module, but they depend on other types in the AsyncAlgorithmsTests
module and I tried to make as few changes as possible. I guess making more of the methods in the extension doesn't feel like a good solution either?
@@ -11,6 +11,7 @@ | |||
|
|||
import XCTest | |||
import AsyncAlgorithms | |||
import AsyncAlgorithms_XCTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume this is needed for the clock tests eh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must have been a miss on my part, I have pushed a commit that removes this.
Thanks! I have only tested importing it to a test target in another package on Darwin so far. I can see if I'm able to test it on Linux as well. |
was able to test this out on linux, seems like it works just fine! |
Resolves #62 by moving the validate extension on XCTestCase to its own module.