This repository was archived by the owner on Mar 28, 2020. It is now read-only.
Disable using -fsanitize=leak from the Clang Driver.
#249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danliew-apple
force-pushed
the
clang_driver_no_lsan
branch
from
f9d194e to
9e32eea
Compare
LeakSanitizer (LSan) is not yet mature for Darwin so until this changes we should avoid supporting it in Swift Clang and AppleClang. rdar://problem/45841334
danliew-apple
force-pushed
the
clang_driver_no_lsan
branch
from
9e32eea to
220790f
Compare
kubamracek
approved these changes
Dec 19, 2018
hyp
approved these changes
Dec 19, 2018
jrose-apple
previously requested changes
Dec 19, 2018
|
In general, |
|
@jrose-apple This change is only for Darwin. Linux should remain unchanged by this PR. |
This patch was originally intended to be internal but @hyp requested it be moved here. |
jrose-apple
dismissed
their stale review
Whoops! I misread the file where the change went to. Okay, I'm still not sure about the Apple-internal bit but the change itself seems reasonable.
|
@jrose-apple The commits shouldn't mention |
danliew-apple
added a commit
to danliew-apple/swift-compiler-rt
that referenced
this pull request
Dec 20, 2018
to the Clang driver in apple/swift-clang#249. This is necessary because the standalone LSan tests will be executed and failed without this patch when using the newer Clang. rdar://problem/45841334
danliew-apple
added a commit
to danliew-apple/swift-compiler-rt
that referenced
this pull request
Dec 20, 2018
to the Clang driver in apple/swift-clang#249. This is necessary because the standalone LSan tests will be executed and will fail without this patch when using the newer Clang. rdar://problem/45841334
delcypher
pushed a commit
to apple/swift-compiler-rt
that referenced
this pull request
Dec 20, 2018
to the Clang driver in apple/swift-clang#249. This is necessary because the standalone LSan tests will be executed and will fail without this patch when using the newer Clang. rdar://problem/45841334
danliew-apple
added a commit
to danliew-apple/swift-compiler-rt
that referenced
this pull request
Dec 31, 2018
to the Clang driver in apple/swift-clang#249. This is necessary because the standalone LSan tests will be executed and will fail without this patch when using the newer Clang. rdar://problem/45841334 (cherry picked from commit 56b6455)
danliew-apple
added a commit
to apple/swift-compiler-rt
that referenced
this pull request
Jan 2, 2019
to the Clang driver in apple/swift-clang#249. This is necessary because the standalone LSan tests will be executed and will fail without this patch when using the newer Clang. rdar://problem/45841334 (cherry picked from commit 56b6455)
hyp
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 22, 2019
to the Clang driver in apple/swift-clang#249. This is necessary because the standalone LSan tests will be executed and will fail without this patch when using the newer Clang. rdar://problem/45841334 apple-llvm-split-commit: 56b645581726e29691a47fec4e2adbb18e7b09e4 apple-llvm-split-dir: compiler-rt/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LeakSanitizer (LSan) is not yet mature for Darwin so until this
changes we should avoid supporting it in Swift Clang and AppleClang.
rdar://problem/45841334