-
Notifications
You must be signed in to change notification settings - Fork 73
Avoid overwriting status changes #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| // | ||
| // DISCLAIMER | ||
| // | ||
| // Copyright 2018 ArangoDB GmbH, Cologne, Germany | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
| // Copyright holder is ArangoDB GmbH, Cologne, Germany | ||
| // | ||
| // Author Ewout Prangsma | ||
| // | ||
|
|
||
| package v1alpha | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| // TestMemberStatusList tests modifying a MemberStatusList. | ||
| func TestMemberStatusList(t *testing.T) { | ||
| list := &MemberStatusList{} | ||
| m1 := MemberStatus{ID: "m1"} | ||
| m2 := MemberStatus{ID: "m2"} | ||
| m3 := MemberStatus{ID: "m3"} | ||
| assert.Equal(t, 0, len(*list)) | ||
|
|
||
| assert.NoError(t, list.Add(m1)) | ||
| assert.Equal(t, 1, len(*list)) | ||
|
|
||
| assert.NoError(t, list.Add(m2)) | ||
| assert.NoError(t, list.Add(m3)) | ||
| assert.Equal(t, 3, len(*list)) | ||
|
|
||
| assert.Error(t, list.Add(m2)) | ||
| assert.Equal(t, 3, len(*list)) | ||
|
|
||
| assert.NoError(t, list.RemoveByID(m3.ID)) | ||
| assert.Equal(t, 2, len(*list)) | ||
| assert.False(t, list.ContainsID(m3.ID)) | ||
| assert.Equal(t, m1.ID, (*list)[0].ID) | ||
| assert.Equal(t, m2.ID, (*list)[1].ID) | ||
|
|
||
| m2.PodName = "foo" | ||
| assert.NoError(t, list.Update(m2)) | ||
| assert.Equal(t, 2, len(*list)) | ||
| assert.True(t, list.ContainsID(m2.ID)) | ||
| x, found := list.ElementByPodName("foo") | ||
| assert.True(t, found) | ||
| assert.Equal(t, "foo", x.PodName) | ||
| assert.Equal(t, m2.ID, x.ID) | ||
|
|
||
| assert.NoError(t, list.Add(m3)) | ||
| assert.Equal(t, 3, len(*list)) | ||
| assert.Equal(t, m1.ID, (*list)[0].ID) | ||
| assert.Equal(t, m2.ID, (*list)[1].ID) | ||
| assert.Equal(t, m3.ID, (*list)[2].ID) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this fails because of network failure, then the version is already incremented. Any retry will now fail with a version mismatch. If we do not retry, we have a changed in memory state which is not written to the API service. Maybe we have to rollback the change in memory to allow for a retry?
The current behaviour might or might not be what we want. If we simply move on then the in memory state is different from the one in the API server. I cannot judge the consequences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is a retry higher up, it MUST call
GetStatus()first to get the latest status and version.So while a network error will cause a state diff between in-memory & persistent in kube-apiserver, this will not affect future updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok