Skip to content

[Maintenance] PropagationMode Enum docs #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
- (Maintenance) Use GoPretty for the Documentation
- (Maintenance) Bump Kubernetes dependency to 1.31.2
- (Documentation) Remove Interactive args for the DebugPackage command
- (Maintenance) PropagationMode Enum docs

## [1.2.43](https://github.com/arangodb/kube-arangodb/tree/1.2.43) (2024-10-14)
- (Feature) ArangoRoute CRD
Expand Down
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -843,6 +843,7 @@ set-api-version/%:
"$(ROOT)/pkg/apis/backup/" \
"$(ROOT)/pkg/apis/networking/" \
"$(ROOT)/pkg/apis/scheduler/" \
"$(ROOT)/pkg/apis/platform/" \
"$(ROOT)/pkg/upgrade/" \
| cut -d ':' -f 1 | sort | uniq \
| xargs -n 1 $(SED) -i "s#github.com/arangodb/kube-arangodb/pkg/apis/$*/v[A-Za-z0-9]\+#github.com/arangodb/kube-arangodb/pkg/apis/$*/v$(API_VERSION)#g"
Expand All @@ -858,6 +859,7 @@ set-api-version/%:
"$(ROOT)/pkg/apis/backup/" \
"$(ROOT)/pkg/apis/networking/" \
"$(ROOT)/pkg/apis/scheduler/" \
"$(ROOT)/pkg/apis/platform/" \
"$(ROOT)/pkg/upgrade/" \
| cut -d ':' -f 1 | sort | uniq \
| xargs -n 1 $(SED) -i "s#DatabaseV[A-Za-z0-9]\+()\.#DatabaseV$(API_VERSION)().#g"
Expand All @@ -873,6 +875,7 @@ set-api-version/%:
"$(ROOT)/pkg/apis/backup/" \
"$(ROOT)/pkg/apis/networking/" \
"$(ROOT)/pkg/apis/scheduler/" \
"$(ROOT)/pkg/apis/platform/" \
"$(ROOT)/pkg/upgrade/" \
| cut -d ':' -f 1 | sort | uniq \
| xargs -n 1 $(SED) -i "s#ReplicationV[A-Za-z0-9]\+()\.#ReplicationV$(API_VERSION)().#g"
Expand Down
56 changes: 42 additions & 14 deletions docs/api/ArangoDeployment.V1.md
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ Possible Values:

### .spec.agents.initContainers.containers

Type: `[]core.Container` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L91)</sup>
Type: `[]core.Container` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L93)</sup>

Containers contains list of containers

Expand All @@ -180,10 +180,14 @@ Links:

### .spec.agents.initContainers.mode

Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L94)</sup>
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L98)</sup>

Mode keep container replace mode

Possible Values:
* `"update"` (default) - Enforce update of pod if init container has been changed
* `"ignore"` - Ignores init container changes in pod recreation flow

***

### .spec.agents.internalPort
Expand Down Expand Up @@ -1235,7 +1239,7 @@ Possible Values:

### .spec.coordinators.initContainers.containers

Type: `[]core.Container` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L91)</sup>
Type: `[]core.Container` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L93)</sup>

Containers contains list of containers

Expand All @@ -1246,10 +1250,14 @@ Links:

### .spec.coordinators.initContainers.mode

Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L94)</sup>
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L98)</sup>

Mode keep container replace mode

Possible Values:
* `"update"` (default) - Enforce update of pod if init container has been changed
* `"ignore"` - Ignores init container changes in pod recreation flow

***

### .spec.coordinators.internalPort
Expand Down Expand Up @@ -2169,7 +2177,7 @@ Possible Values:

### .spec.dbservers.initContainers.containers

Type: `[]core.Container` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L91)</sup>
Type: `[]core.Container` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L93)</sup>

Containers contains list of containers

Expand All @@ -2180,10 +2188,14 @@ Links:

### .spec.dbservers.initContainers.mode

Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L94)</sup>
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L98)</sup>

Mode keep container replace mode

Possible Values:
* `"update"` (default) - Enforce update of pod if init container has been changed
* `"ignore"` - Ignores init container changes in pod recreation flow

***

### .spec.dbservers.internalPort
Expand Down Expand Up @@ -3235,7 +3247,7 @@ Possible Values:

### .spec.gateways.initContainers.containers

Type: `[]core.Container` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L91)</sup>
Type: `[]core.Container` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L93)</sup>

Containers contains list of containers

Expand All @@ -3246,10 +3258,14 @@ Links:

### .spec.gateways.initContainers.mode

Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L94)</sup>
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L98)</sup>

Mode keep container replace mode

Possible Values:
* `"update"` (default) - Enforce update of pod if init container has been changed
* `"ignore"` - Ignores init container changes in pod recreation flow

***

### .spec.gateways.internalPort
Expand Down Expand Up @@ -4912,7 +4928,7 @@ Possible Values:

### .spec.single.initContainers.containers

Type: `[]core.Container` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L91)</sup>
Type: `[]core.Container` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L93)</sup>

Containers contains list of containers

Expand All @@ -4923,10 +4939,14 @@ Links:

### .spec.single.initContainers.mode

Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L94)</sup>
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L98)</sup>

Mode keep container replace mode

Possible Values:
* `"update"` (default) - Enforce update of pod if init container has been changed
* `"ignore"` - Ignores init container changes in pod recreation flow

***

### .spec.single.internalPort
Expand Down Expand Up @@ -6047,7 +6067,7 @@ Possible Values:

### .spec.syncmasters.initContainers.containers

Type: `[]core.Container` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L91)</sup>
Type: `[]core.Container` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L93)</sup>

Containers contains list of containers

Expand All @@ -6058,10 +6078,14 @@ Links:

### .spec.syncmasters.initContainers.mode

Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L94)</sup>
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L98)</sup>

Mode keep container replace mode

Possible Values:
* `"update"` (default) - Enforce update of pod if init container has been changed
* `"ignore"` - Ignores init container changes in pod recreation flow

***

### .spec.syncmasters.internalPort
Expand Down Expand Up @@ -6973,7 +6997,7 @@ Possible Values:

### .spec.syncworkers.initContainers.containers

Type: `[]core.Container` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L91)</sup>
Type: `[]core.Container` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L93)</sup>

Containers contains list of containers

Expand All @@ -6984,10 +7008,14 @@ Links:

### .spec.syncworkers.initContainers.mode

Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L94)</sup>
Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.2.43/pkg/apis/deployment/v1/server_group_init_containers.go#L98)</sup>

Mode keep container replace mode

Possible Values:
* `"update"` (default) - Enforce update of pod if init container has been changed
* `"ignore"` - Ignores init container changes in pod recreation flow

***

### .spec.syncworkers.internalPort
Expand Down
8 changes: 6 additions & 2 deletions pkg/apis/deployment/v1/server_group_init_containers.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//
// DISCLAIMER
//
// Copyright 2016-2024 ArangoDB GmbH, Cologne, Germany
// Copyright 2016-2025 ArangoDB GmbH, Cologne, Germany
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -58,7 +58,7 @@ type ServerGroupInitContainerMode string

func (s *ServerGroupInitContainerMode) Get() ServerGroupInitContainerMode {
if s == nil {
return ServerGroupInitContainerUpdateMode // default
return ServerGroupInitContainerDefaultMode // default
}

return *s
Expand All @@ -78,6 +78,8 @@ func (s *ServerGroupInitContainerMode) Validate() error {
}

const (
// ServerGroupInitContainerDefaultMode default mode
ServerGroupInitContainerDefaultMode = ServerGroupInitContainerIgnoreMode
// ServerGroupInitContainerIgnoreMode ignores init container changes in pod recreation flow
ServerGroupInitContainerIgnoreMode ServerGroupInitContainerMode = "ignore"
// ServerGroupInitContainerUpdateMode enforce update of pod if init container has been changed
Expand All @@ -91,6 +93,8 @@ type ServerGroupInitContainers struct {
Containers []core.Container `json:"containers,omitempty"`

// Mode keep container replace mode
// +doc/enum: update|Enforce update of pod if init container has been changed
// +doc/enum: ignore|Ignores init container changes in pod recreation flow
Mode *ServerGroupInitContainerMode `json:"mode,omitempty"`
}

Expand Down
8 changes: 6 additions & 2 deletions pkg/apis/deployment/v2alpha1/server_group_init_containers.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//
// DISCLAIMER
//
// Copyright 2016-2024 ArangoDB GmbH, Cologne, Germany
// Copyright 2016-2025 ArangoDB GmbH, Cologne, Germany
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -58,7 +58,7 @@ type ServerGroupInitContainerMode string

func (s *ServerGroupInitContainerMode) Get() ServerGroupInitContainerMode {
if s == nil {
return ServerGroupInitContainerUpdateMode // default
return ServerGroupInitContainerDefaultMode // default
}

return *s
Expand All @@ -78,6 +78,8 @@ func (s *ServerGroupInitContainerMode) Validate() error {
}

const (
// ServerGroupInitContainerDefaultMode default mode
ServerGroupInitContainerDefaultMode = ServerGroupInitContainerIgnoreMode
// ServerGroupInitContainerIgnoreMode ignores init container changes in pod recreation flow
ServerGroupInitContainerIgnoreMode ServerGroupInitContainerMode = "ignore"
// ServerGroupInitContainerUpdateMode enforce update of pod if init container has been changed
Expand All @@ -91,6 +93,8 @@ type ServerGroupInitContainers struct {
Containers []core.Container `json:"containers,omitempty"`

// Mode keep container replace mode
// +doc/enum: update|Enforce update of pod if init container has been changed
// +doc/enum: ignore|Ignores init container changes in pod recreation flow
Mode *ServerGroupInitContainerMode `json:"mode,omitempty"`
}

Expand Down
Loading