Skip to content

[Feature] Allow to continue if ResignServer job is gone #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

[Feature] Allow to continue if ResignServer job is gone #1824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- (Feature) Agency DBServer Discovery
- (Bugfix) Fix Manifests
- (Bugfix) Agency Cache Reload
- (Feature) Allow to continue if ResignServer job is gone

## [1.2.44](https://github.com/arangodb/kube-arangodb/tree/1.2.44) (2025-02-03)
- (Maintenance) Kubernetes 1.31.1 libraries
Expand Down
6 changes: 5 additions & 1 deletion pkg/deployment/reconcile/action_enforce_resign_leadership.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,12 @@ func (a *actionEnforceResignLeadership) CheckProgress(ctx context.Context) (bool
a.log.Info("Job finished")
// Remove key
a.actionCtx.Add(resignLeadershipJobID, "N/A", true)
case state.JobPhasePending, state.JobPhaseToDo:
// Job not yet completed
return false, false, nil
case state.JobPhaseUnknown:
a.log.Str("status", string(jobStatus)).Error("Resign server job unknown status")
a.actionCtx.Add(resignLeadershipJobID, "N/A", true)
a.log.Str("status", string(jobStatus)).Error("Resign server job unknown status, retry")
return false, false, nil
default:
return false, false, nil
Expand Down