-
Notifications
You must be signed in to change notification settings - Fork 218
Use Github workflows to compile examples and spell check #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Github workflows to compile examples and spell check #34
Conversation
@facchinm @cmaglie @lxrobotics @mastrolinux @rsora please review this along with https://github.com/arduino-libraries/actions/tree/master/compile-examples (which is based on https://help.github.com/en/articles/creating-a-docker-container-action). @rsora was in favour of use Node.js instead of Docker + bash for the common Github action in terms of testability, but I think this is good to get us going for now. We can introduce Node.js down the road as needed. |
👍 I like how clean everything is. Doesn't need a rocket scientist to comprehend what's happening. Nice work 😉 |
Please do not let bash proliferate 😸 Anyway, the action properly hides the boilerplate so 👍 from me. May I suggest to move the https://github.com/arduino-libraries/actions/tree/master/compile-examples code to https://github.com/arduino/actions? |
58d1edd
to
e3d07c8
Compare
I've added spell check support In: https://github.com/arduino-libraries/actions/tree/master/spell-check (it uses code spell) ... this works and I've fixed some spelling :)
@rsora I think I'm ok with this, we might need to rename the action names to indicate they are for Arduino Libraries only, with we get for free sort of because of |
@sandeepmistry as per https://help.github.com/en/articles/workflow-syntax-for-github-actions#example-using-a-public-action-in-a-subdirectory we should be able to do something like this |
@rsora excellent suggestion! Stay tuned for a pull request in that repo! #hacktoberfest |
2b51eb9
to
aa38994
Compare
This should be good to go now, I've removed the Travis CI config as well. We need to re-add the badges to the read me once merged. |
b9adb63
to
862f55e
Compare
Alternative to PR #31 and #32.
Uses
compile-examples
action from: https://github.com/arduino-libraries/actionsThis will allow us to have a super minimal
.yml
file in allarduino-libraries
repos, and re-use a common action from a central Github repo.