Skip to content

fix write() in BearSSLClient.cpp #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2022
Merged

fix write() in BearSSLClient.cpp #61

merged 1 commit into from
Jan 28, 2022

Conversation

etakata
Copy link
Contributor

@etakata etakata commented Jan 27, 2022

This PR resolves the issue(#60): failed to send a long date ( > 512 bytes ).

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jan 27, 2022
@github-actions
Copy link

Memory usage change @ b9055e4

Board flash % RAM for global variables %
arduino:megaavr:uno2018 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/SHA1
flash		 % examples/SHA1
RAM for global variables		 % examples/SHA256
flash		 % examples/SHA256
RAM for global variables		 % examples/WiFiSSLClient
flash		 % examples/WiFiSSLClient
RAM for global variables		 % examples/MKRGSMSSLClient
flash		 % examples/MKRGSMSSLClient
RAM for global variables		 %
arduino:megaavr:uno2018 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/SHA1<br>flash,%,examples/SHA1<br>RAM for global variables,%,examples/SHA256<br>flash,%,examples/SHA256<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/MKRGSMSSLClient<br>flash,%,examples/MKRGSMSSLClient<br>RAM for global variables,%
arduino:megaavr:uno2018,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,,,,,0,0.0,0,0.0

@etakata etakata mentioned this pull request Jan 28, 2022
Closed
@pennam pennam mentioned this pull request Jan 28, 2022
Closed
aentinger
aentinger approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aentinger
Copy link
Contributor

Thank you @etakata 🚀 !

@aentinger aentinger merged commit 2231c31 into arduino-libraries:master Jan 28, 2022
@per1234 per1234 linked an issue Jan 28, 2022 that may be closed by this pull request
failed to send a long data ( > 512bytes ) #60
Closed
@pennam pennam mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aentinger aentinger aentinger approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed to send a long data ( > 512bytes )
3 participants
@etakata @aentinger @per1234