Skip to content

Add DigiCertGlobalRootG2 and MicrosoftRSARootCertificateAuthority2017… #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RLeclair
Copy link
Contributor

… as trust anchor

Adding DigiCertGlobalRootG2 and MicrosoftRSARootCertificateAuthority2017 as trust anchors.

  • Added .cer files to extras/TrustAnchors/
  • Ran *brssl ta .cer on TrustAnchors folder with added certificates, added new structures to existing src/BearSSLTrustAnchors.h file

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Memory usage change @ b28fbcd

Board flash % RAM for global variables %
arduino:megaavr:uno2018 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 0 - +1040 0.0 - +0.4 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 0 - +1040 0.0 - +0.4 0 - 0 0.0 - 0.0
Click for full report table
Board examples/SHA1
flash
% examples/SHA1
RAM for global variables
% examples/SHA256
flash
% examples/SHA256
RAM for global variables
% examples/WiFiSSLClient
flash
% examples/WiFiSSLClient
RAM for global variables
% examples/MKRGSMSSLClient
flash
% examples/MKRGSMSSLClient
RAM for global variables
%
arduino:megaavr:uno2018 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 1040 0.4 0 0.0
arduino:samd:mkrgsm1400 0 0.0 0 0.0 0 0.0 0 0.0 1040 0.4 0 0.0
Click for full report CSV
Board,examples/SHA1<br>flash,%,examples/SHA1<br>RAM for global variables,%,examples/SHA256<br>flash,%,examples/SHA256<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/MKRGSMSSLClient<br>flash,%,examples/MKRGSMSSLClient<br>RAM for global variables,%
arduino:megaavr:uno2018,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,1040,0.4,0,0.0
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,,,,,1040,0.4,0,0.0

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 25, 2022
@RLeclair
Copy link
Contributor Author

Hello @per1234, wanted to know what else is needed for us to move forward with merging. Thanks!

@RLeclair
Copy link
Contributor Author

Hi @per1234, wanted to check if you had the chance to look at the comment above! Is there anyone I can reach out to in order to move forward with this? Thanks!

@per1234
Copy link
Contributor

per1234 commented Nov 29, 2022

Hi @RLeclair. Thanks so much for your pull request. My role in this project is janitorial in nature. I am not in a position to decide about pull request merges. One of the other maintainers may be able to answer your question.

@RLeclair
Copy link
Contributor Author

Thank you @per1234! @facchinm wanted to check on the above to see if there's anything else I can do to move this forward. If there's anyone else I should reach out to please let me know. Thank you!

@facchinm
Copy link
Contributor

Fine for me, merging 🙂 thx!

@facchinm facchinm merged commit ccbc679 into arduino-libraries:master Nov 30, 2022
@RLeclair
Copy link
Contributor Author

RLeclair commented Dec 1, 2022

Thanks @facchinm :) just one more question, I saw the latest release was Aug 02, 2021. Is there a planned release date for 1.7.3 which would include the changes here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants