Skip to content

pid1.setGains() uses float as input variables [AEK-309] #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 29, 2022
Merged

pid1.setGains() uses float as input variables [AEK-309] #38

merged 3 commits into from
Dec 29, 2022

Conversation

aliphys
Copy link
Contributor

@aliphys aliphys commented Jul 30, 2021

Documentation now refers to pid1.setGains(float P, float I, float D)
instead of pid1.setGains(int P, int I, int D).

@aliphys
Copy link
Contributor Author

aliphys commented Jul 30, 2021

@Rocketct @per1234 can you kindly review?

Rocketct
Rocketct approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@Rocketct Rocketct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aentinger aentinger merged commit 2d83df4 into arduino-libraries:master Dec 29, 2022
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: documentation Related to documentation for the project labels Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rocketct Rocketct Rocketct approved these changes

Assignees
No one assigned
Labels
topic: documentation Related to documentation for the project type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aliphys @Rocketct @aentinger @per1234