Skip to content

Add compatibility to Portenta H7 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 30, 2022
Merged

Conversation

facchinm
Copy link
Contributor

@facchinm facchinm commented Nov 3, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Memory usage change @ f89b416

Board flash % RAM for global variables %
arduino:samd:mkr1000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrfox1200 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrvidor4000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1310 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrzero 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Flasher
flash
% examples/Flasher
RAM for global variables
% examples/MKR/Motor_test
flash
% examples/MKR/Motor_test
RAM for global variables
% examples/MKR/Motor_test_encoder
flash
% examples/MKR/Motor_test_encoder
RAM for global variables
% examples/MKR/Servo_test
flash
% examples/MKR/Servo_test
RAM for global variables
% examples/MKR/Test
flash
% examples/MKR/Test
RAM for global variables
%
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 N/A N/A N/A N/A
arduino:samd:mkrfox1200 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 N/A N/A N/A N/A
arduino:samd:mkrgsm1400 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 N/A N/A N/A N/A
arduino:samd:mkrnb1500 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 N/A N/A N/A N/A
arduino:samd:mkrvidor4000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 N/A N/A N/A N/A
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 N/A N/A N/A N/A
arduino:samd:mkrwan1310 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 N/A N/A N/A N/A
arduino:samd:mkrwifi1010 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 N/A N/A N/A N/A
arduino:samd:mkrzero 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 N/A N/A N/A N/A
Click for full report CSV
Board,examples/Flasher<br>flash,%,examples/Flasher<br>RAM for global variables,%,examples/MKR/Motor_test<br>flash,%,examples/MKR/Motor_test<br>RAM for global variables,%,examples/MKR/Motor_test_encoder<br>flash,%,examples/MKR/Motor_test_encoder<br>RAM for global variables,%,examples/MKR/Servo_test<br>flash,%,examples/MKR/Servo_test<br>RAM for global variables,%,examples/MKR/Test<br>flash,%,examples/MKR/Test<br>RAM for global variables,%
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A
arduino:samd:mkrfox1200,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A
arduino:samd:mkrvidor4000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A
arduino:samd:mkrwan1310,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A
arduino:samd:mkrzero,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,N/A,N/A,N/A,N/A

@per1234
Copy link
Contributor

per1234 commented Nov 5, 2021

Fixes #40
Supersedes #39

@facchinm
Copy link
Contributor Author

facchinm commented Nov 5, 2021

I don't know why the CI keeps failing but if I compile locally it's ok... 🤔

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add mbed_portenta and mbed to the architectures field of library.properties .

@per1234
Copy link
Contributor

per1234 commented Nov 5, 2021

I don't know why the CI keeps failing but if I compile locally it's ok..

Are you referring to this failure @facchinm?
https://github.com/arduino-libraries/ArduinoMotorCarrier/runs/4093746348?check_suite_focus=true#step:3:72

  /home/runner/work/ArduinoMotorCarrier/ArduinoMotorCarrier/examples/Flasher/Flasher.ino:115:25: error: call of overloaded 'write(uint32_t)' is ambiguous
     Wire.write((uint32_t)0);
                           ^

@facchinm
Copy link
Contributor Author

facchinm commented Nov 5, 2021

@per1234
Copy link
Contributor

per1234 commented Nov 5, 2021

I apologize for the confusion @facchinm. This is the result of my poor design of the log output from the arduino/compile-sketches action. I need to make some time to work on that (HWCI-234).

From https://github.com/arduino-libraries/ArduinoMotorCarrier/runs/4093746348?check_suite_focus=true#step:3:113

Compiling previous version of sketch to determine memory usage change

So this failure was from when the action checked out the base ref of this PR (master branch) to do a second compilation to determine the size deltas. That failure is expected.

You can see here that the compilation from when the head ref of this PR (portenta_compatibility branch) was checked out was successful:
https://github.com/arduino-libraries/ArduinoMotorCarrier/runs/4093746348?check_suite_focus=true#step:3:109

The compilations of the base ref are done solely for data collection purposes. Their result does not affect the status of the CI, but only the informational size deltas report comment. The only reason the Portenta H7 compilation job failed was the error that occurred during the "Flasher" example compilation. If that error was resolved or the CI workflow reconfigured to skip that example, the job would pass ✔️

@facchinm
Copy link
Contributor Author

facchinm commented Nov 5, 2021

Ahhhnn got it 😄 (you probably told me 1000 times but I still end up forgetting this information 😝 )
The Wire.write(0) ambiguity should be fixed at API level, so I'd leave the "offending code" here and create the specific issue in the proper (core or api) repo

@aentinger aentinger merged commit f9c66ed into master Dec 30, 2022
@aentinger aentinger deleted the portenta_compatibility branch December 30, 2022 07:32
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Portenta H7 RESET already declared for Portenta H7
3 participants