Providing empty functions for functions defined pure virtual in ESP8266::Client.h #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,6 +67,7 @@ class MqttClient : public Client { | |||
| // from Client | |||
| virtual int connect(IPAddress ip, uint16_t port = 1883); | |||
| virtual int connect(const char *host, uint16_t port = 1883); | |||
| virtual int connect(const IPAddress& ip, uint16_t port) { }; /* ESP8266 core defines this pure virtual in Client.h */ | |||
There was a problem hiding this comment.
@lxrobotics should we consider wrapping these in #ifdef ESP8266 ?
There was a problem hiding this comment.
@sandeepmistry Yes that would be definitely a good idea 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.