-
Notifications
You must be signed in to change notification settings - Fork 81
initializer order wrong of _tx_payload_buffer_size - causes compile error #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thomas Baust seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Memory usage change @ 118b0f1
Click for full report table
Click for full report CSV
|
Memory usage change @ d76cbe5
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you @tbaust 🚀
Just the order needs to be changed to get rid of the reorder error (warning enabled as error)
.pio\libdeps\esp32dev\ArduinoMqttClient\src\MqttClient.h:184:11: error: 'MqttClient::_willFlags' will be initialized after [-Werror=reorder]
uint8_t _willFlags;
^
.pio\libdeps\esp32dev\ArduinoMqttClient\src\MqttClient.h:146:18: error: 'short unsigned int MqttClient::_tx_payload_buffer_size' [-Werror=reorder]
unsigned short _tx_payload_buffer_size;