Skip to content

Download url parser discards port #28

Closed
@f0x52

Description

@f0x52

After being quite confused why the OTA library could not connect to my storage server, I realized from this code that the port I specified (8080) wasn't being used at all.

https://github.com/arduino-libraries/Arduino_ESP32_OTA/blob/main/src/Arduino_ESP32_OTA.cpp#L119 always sets port to 80 for http and 443 for https, and the URI parser seems to not handle : at all (https://github.com/arduino-libraries/Arduino_ESP32_OTA/blob/main/src/decompress/utility.cpp#L88).

That last function is quite confusing, so no easy fix PR from my side, alas.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions