-
Notifications
You must be signed in to change notification settings - Fork 60
Added simple filtering and object property value checking #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Joe Andolina seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Memory usage change @ 607acab
Click for full report table
Click for full report CSV
|
CLA Signed, not showing though. |
Hi @Phando. Thanks so much for your pull request! The CLA check is done on the creator of the commits, not the creator of the pull request. The creator of the commits is determined by the GitHub user who has registered the email address specified in the commit metadata. If you look at the commits, you can see that they are not associated with your GitHub account. This is caused by the way you have configured your local Git settings. Please follow these instructions to resolve the issue: Hopefully the check will automatically pass once that has been done. If not, please comment here and we will investigate. |
@per1234 It looks like all my submits are associated with my account. |
The email address for the commits is: Have you added that email to your GitHub account according to these instructions?:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Added two new functions to handle filtering (filter) and testing for object property value testing (hasPropertyEqual).
bool hasPropertyEqual returns true if the JSONVar has a property named key and that key is equal to value.
myVar[key] != null && myVal[key] == value
JSONVar filter returns a JSONVar object containing objects who have properties named key and values matching value.
If no values are found it returns JSONVar(NULL, NULL)
If one value is found it returns a JSONVar Object
If multiple values are found it returns a JSONVar Array