-
Notifications
You must be signed in to change notification settings - Fork 31
Solves issue of stalling audio playback after 5-8 .wav files #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Solves issue #6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use descriptive commit titles. When someone is browsing the commit history or blame, they should be able to get a good idea of the purpose of the commit just from the title. "Update SimpleAudioPlayerZero.ino" is pretty much useless. We know you updated it, but why? Currently, in order to find out what the commit does, and why, we need to open the commit, read the message, then track down the referenced issue report. Sometimes we might be looking through dozens of commit messages to find the information we need so if we have to do that every time, it makes it an unnecessarily time consuming process.
There's a really great article on this subject here:
https://chris.beams.io/posts/git-commit/
very much worth reading.
Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
@per1234 I shall be more descriptive in my future PRs, I am still in the process of learning how to contribute effectively. Thank you for taking the time to patiently tell me how to do things.
I will read the article for sure. Also, I have committed the requested changes, so kindly review them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stalling is most likely due to memory leak, and how does including non existent method solves the issue?
Solves issue #6