Adafruit_ST7735.h and glcdfont.c preprocessor #if ARDUINO_ARCH_STM32 not enough

[pabloandresm]

in these two lines:

TFT/src/utility/Adafruit_ST7735.h

Line 143 in 6941d00

defined(ARDUINO_ARCH_STM32)

TFT/src/utility/glcdfont.c

Line 2 in 6941d00

!defined(ARDUINO_ARCH_STM32)

there is a test for definition or missing definition ARDUINO_ARCH_STM32, and it is not enough.

I had to add ARDUINO_ARCH_STM32F1 too.

Could you change those lines please?

for the glcdfont.c
instead of
!defined(ARDUINO_ARCH_STM32)
use
!defined(ARDUINO_ARCH_STM32) && !defined(ARDUINO_ARCH_STM32F1)

for the Adafruit_ST7735.h:
instead of defined(ARDUINO_ARCH_STM32)
use
defined(ARDUINO_ARCH_STM32) || defined(ARDUINO_ARCH_STM32F1)

[fpistm]

Just a quick note:
ARDUINO_ARCH_STM32F1 is for this core: https://github.com/rogerclarkmelbourne/Arduino_STM32
ARDUINO_ARCH_STM32is for this core: https://github.com/stm32duino/Arduino_Core_STM32

So issue is mainly that Roger's core support has not been added.
Title should be changed to something like: Add rogerclarkmelbourne/Arduino_STM32 support

[pabloandresm]

I don't think that it is not supported. The display works fine regardless of the STM32xxxxx version of the chipset.

I think it is just a wrong define usage.

[fpistm]

I think it is just a wrong define usage.

That is the point. It is not a wrong define usage. They are simply not for the same core. 😉