Float for the String Class

[SebiTimeWaster]

I wrote a patch for the String Class to incorporate float: http://www.timewasters-place.com/arduino-string-and-float/

Please include it in the next release.

thanks

[ffissore]

can you please provide a pull request version of your patch and some test code that can help us quickly evaluate it?

[SebiTimeWaster]

i am not entirely sure what a "pull request version" really is, but some sources talk about a public git repository to provide sources, and i have no such thing. can't you just merge the files into your repository?

the test code is included in my blog entry.

[SebiTimeWaster]

also that patch is used by quite some people (even a school project), and no one ever complained about a bug.

[SebiTimeWaster]

i don't want to be impatient or something, but the Float and String post on my blog is by far the most visited, so it seems that this issue is pressing for most arduino users.

[tevino]

@SebiTimeWaster I'm using your patch, it works like a charm, I'd like it to be included in the future release too, may I send your patch as a pull request for you?

[SebiTimeWaster]

@tevino that would be very nice since i have no idea how to do that... thanx in advance!

[tevino]

@SebiTimeWaster I'm not sure if I'm pulling into the right branch, since I can't find any documentation about contribute, here it is #1443

[tigoe]

Would also be useful to have a patch that converts the other way: String(34.56) returns "34.56"

[SebiTimeWaster]

@tigoe it does all that. take a look at my blog, it is described there.

[tigoe]

Great. Did you put it in gitHub and put in a pull request?

On Sat, Jun 1, 2013 at 6:13 AM, SebiTimeWaster notifications@github.comwrote:

@tigoe https://github.com/tigoe it does all that. take a look at my
blog, it is described there.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1297#issuecomment-18786652
.

Tom Igoe

[SebiTimeWaster]

@tigoe tevino did that for me (thanx again). take a look at #1443

[cmaglie]

Merged, thank you.

82a2c1d

[tigoe]

no, thank you! Happy to see it.

On Jun 6, 2013, at 2:18 PM, Cristian Maglie notifications@github.com wrote:

Merged, thank you.

82a2c1d

—
Reply to this email directly or view it on GitHub.