Switching Tabs broken

[NicoHood]

Ctrl Alt Right switches 2 tabs for me. If I hold it for a few seconds the IDE switches like crazy. Afterwards I cannot type anything in the text editor again. Compiling also doesnt work.

I also was confused how to even get to the tabs on the right. Scrolling over all tabs would make most sense, that is what I intuitive tried. As an alternative simple buttons would be also acceptable.

Example sketch:
https://github.com/watterott/HDMI-Display/tree/master/software/HDMI-Display

[per1234]

If you click the down arrow(tabs menu) on the right of the tabs bar it starts working correctly.

[matthijskooijman]

For ctrl+alt+left/right switching two tabs, it turns out that the key is handled both by EditorListener, and registered as a shortcut key on the next tab / prev tab menu items in the tab bar menu. Fixing that should be a matter of removing the EditorListener handling, I'll include this in the cleanup PR I'm preparing.

As for the "cannot type" thing, I cannot reproduce this here. I see the "switching like crazy" part, where the title updates continuously, the selected tab updates more slowly and once you let go of the key combo, it still continues to switch a while longer. With my cleaned up code, this crazy behaviour seems to be gone, especially when the duplicate keybinding is removed.

Perhaps you can see if you can reproduce the "cannot type" thing using my cleaned up code? I've pushed a preliminary version here: https://github.com/matthijskooijman/Arduino/tree/cleanup (branch is prone to rebasing and force pushing).

As for improving the navigation of tabs when they do not fit on the screen, #3601 is about that, so let's keep discussion about that in that ticket.

[matthijskooijman]

@NicoHood , Could you see if #4279 fixes these issues for you? If you have time, a review of the code would also be welcome :-)

[matthijskooijman]

@NicoHood you said that #4279 improves a bit, but doesn't fix this issue entirely. Could you see if #4363 does make it behave as expected?

[NicoHood]

Same behavior as described before (after the minor improvement). I just tested to hold down the keys and it breaks again. Haven't tested anything else.

[matthijskooijman]

@NicoHood thanks for checking. Interestingly enough I cannot reproduce your issue here, making this hard to fix. If you can somehow find out what happens, be sure to let us know, but for now I won't be looking into this further (it's a bit of a minor issue anyway).

[NicoHood]

You might want to try elementary os in a vm real quick? It might be gnome3 related and still a problem? Even though its quite minor now, since it is fixed as long as you dont hold the buttons 2 seconds down. (I'd still leave this issue open though)