Compiler won't notice if files are deleted

[rkost]

For version 1.6.11 the compiler throws a "multiple definition of `DummyClass::getString()'" error if one deletes the DummyClass files (DummyClass.h/.cpp) and copies it to e.g. the main .ino file.

Using the option "use external editor"

[facchinm]

Maybe related to Editor refactor and files not getting actually deleted? @matthijskooijman

[per1234]

@rkost, does this problem still occur for you with Arduino IDE 1.8.3?

[rkost]

Ooops, sorry. I will test this as soon as I can. Didn't noticed your comment.

[per1234]

@rkost, did you ever get a chance to check if this still occurs in the latest IDE version?

[rkost]

So I just re-tested it, and yes: The compiler still does not care if I delete a file called e.g. "Log.h" and use macros (that are only defined in this very file) elsewhere. I just took a look into the temp directory that is obiously being used by this IDE (in my case it was /tmp/arduino_build_761725/sketch) and there are copies of all the files I deleted in the directory I was working in (e.g. /home/rkost/repos/test).

So it seems that the files are not watched properly. I did not do things like that before, but I think that one might just delete the file(s) in the temp directory when inotify sends the delete_self event for any of the sketch's files.

I don't know if this is important for you, but here are my system specs (hardware should be irrelevant?): Arch Linux 64-Bit with Kernel v4.14.13-1 on Intel, Arduino Version 1.8.5.

I also tried this in one of my virtual machines, just to be sure that there is no special shit going on my personal machine. Was able to reproduce it on Ubuntu 17.10, so it seems to be a common problem on Linux. I will have a look at windows 10 on Sunday.

[rkost]

Uh. And one more thing: The actual Editor gui is updating properly. If I delete a file Log.h in the working dir, it will properly disappear from the file tabs at the top of the editor. It also properly re-appears if I restore that file.

[facchinm]

Hi @rkost, I'd ask you to test the beta version of the IDE (1.9) and report if this behaviour is solved. We added both a watcher on the sketch folder which should work in both "external editor" and normal mode.

[matthijskooijman]

This is a problem in the builder: It copies all files into the temp directory, but does not clean out the temp directory beforehand. I've been planning to fix this by skipping the copy altogether and compiling straight out of the original sketch directory, but haven't gotten around to implementing that yet...

[rkost]

Hey @facchinm,
I tested it on the beta version (1.9-build-35) and as @matthijskooijman said, the bug still persists. The file won't be deleted in the temp directory if I remove it inside the normal project directory.

Thanks by the way for all the time you are spending on this project!

[facchinm]

MAYBE I got it. Is your sketch (or any of its parent folders) a symlink? I just noticed that the Beta watcher doesn't follow symlinks so your bugreport would still apply.

[rkost]

Hmm, no. My project does not contain any symlinks. Also the path to the project does not consist of any symlinks (It is as simple as /home/rkost/repos/company/projectName). I don't know if the watcher has problems watching project folders that conain subdirectories. In my case:

├── config
│   └── robot.dimension.h
├── constants.h
├── JointCalibration.cpp
├── JointCalibration.h
├── Joint.cpp
├── Joint.h
├── Leg12X.cpp
├── Leg12X.h
├── Leg.h
├── LICENSE
├── Log.h
├── Motor.cpp
├── Motor.h
├── README.md
├── src
│   ├── calibrationUI
│   │   ├── CalibrationViaConsole.cpp
│   │   └── CalibrationViaConsole.h
│   ├── Module.h
│   ├── ModuleHandler.cpp
│   ├── ModuleHandler.h
│   ├── serialRemoteControl
│   │   ├── SerialRemoteControl.cpp
│   │   ├── SerialRemoteControl.h
│   │   ├── SerialRemoteInterface.cpp
│   │   └── SerialRemoteInterface.h
│   ├── servo
│   │   ├── Servo.cpp
│   │   ├── Servo.h
│   │   └── ServoTimers.h
│   └── walkingEngines
│       ├── WalkingEngine124.cpp
│       ├── WalkingEngine124.h
│       ├── WalkingEngineGeneric.cpp
│       └── WalkingEngineGeneric.h
├── tools
│   └── Z12x_3.ggb
├── UltrasonicSensor.cpp
├── UltrasonicSensor.h
└── Zuri.ino

How does the watcher handle unknown files? The sketch also contains a .git dir...

[facchinm]

Ah, now I get the point. The watcher only watches the first folder level to update the tabs on demand. It doesn't watch any subfolder currently. I'll prepare a PR to address it