Fixed NPE in buildProgrammersMenu #10545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some platforms may not define directly 'build.core' because it may be defined through a custom menu. For example, the arduboy platform has in the boards.txt: [...] menu.core=Core [...] # core # arduboy-homemade.menu.core.arduboy-core=Arduboy optimized core arduboy-homemade.menu.core.arduboy-core.build.core=arduboy arduboy-homemade.menu.core.arduino-core=Standard Arduino core arduboy-homemade.menu.core.arduino-core.build.core=arduino:arduino [...] the build.core is determined only after applying the submenu options.
|
Tested, performing very well, exceptions gone. |
|
✅ Build completed. Please test this code using one of the following: ⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10545-BUILD-982-linux32.tar.xz ℹ️ The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some platforms may not define directly
build.corebecause it may be defined through a custom menu.For example, the arduboy platform has in the boards.txt:
the build.core is determined only after applying the submenu options.
Before this patch the IDE would not start due to a NullPointerException, this PR fix the exception by checking if the
build.coreproperty is directly defined. If it is not the current platform is used instead of an eventual referenced platform.The proper fix requires to apply all the custom properties and to find the referenced platform, but this is much more involved and requires a much complex PR, the purpose of this PR is to fix the crash and to allow the IDE to start.