Skip to content

Allow USB descriptor strings to be defined in boards.txt (redux) #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

projectgus
Copy link
Contributor

(This is a reworking of #1421 when I realised a much more elegant way to do it.)

As per discussion list:
https://groups.google.com/a/arduino.cc/forum/?hl=en-US&fromgroups#!topic/developers/Ml_djoFXyPU

I'll reply to that thread with more detail.

cmaglie added a commit to cmaglie/Arduino that referenced this pull request Jul 17, 2013
@cmaglie
Copy link
Member

cmaglie commented Jul 23, 2013

@projectgus

Thanks, I've merged almost all of your implementation, but I've changed your quotedSplit because it has some bugs that makes compiling fail on some boards. I made another version that allows two type of quoting with ' or with ", so you can write '-DUSB_PRODUCT="My product"'.

There is also a porting for the Due board, you can find it together with your commits starting from here and goind backward: d6a5e41

C

@cmaglie cmaglie closed this Jul 23, 2013
@projectgus
Copy link
Contributor Author

Thanks so much Cristian! Commits look good.

I can't believe I forgot the Due, sorry about that. FWIW if I send you similar pull requests in future, feel free to bounce them back to me with issues to fix. Not my intention to pour more work on you, you seem plenty busy already. :)

  • Angus

PS The unit tests for the string quoting tools are also a nice addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants