Skip to content

Fixed "runtime.hardware.path" and "runtime.platform.path" values #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2014

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jan 5, 2014

This should fix #1176 and #1761.

"runtime.hardware.path" now contains the path to the hardware folder of the currently selected board (for example sketchbook/hardware/provider).
"runtime.platform.path" is a new variable with the path down to the specific platform (for example sketchbook/hardware/rovider/avr).

"runtime.hardware.path" now contains the path to the hardware folder
of the currently selected board and "runtime.platform.path" the path
to the specific platform.

This should fix arduino#1176 and arduino#1761.
@matthijskooijman
Copy link
Collaborator

Wouldn't it make more sense to set these properties in createBuildPreferences() instead of selectBoard()?

https://github.com/cmaglie/Arduino/blob/4dc21cee6c5d2c758519be3782109c221c3b0ff1/app/src/processing/app/debug/Compiler.java#L137

@cmaglie
Copy link
Member Author

cmaglie commented Jan 9, 2014

@matthijskooijman
the method createBuildPreferences(..) is not used when burning bootloaders (is placed under Compiler class) so I need to set the properties in selectBoard() to make them available in burnBootloader().
BTW your consideration is right, when compiling or burning bootloaders the preferences are built in a very similar way, and probably we can factor this out in a common method to use for everything.

cmaglie added a commit that referenced this pull request Jan 9, 2014
Fixed "runtime.hardware.path" and "runtime.platform.path" values
@cmaglie cmaglie merged commit 8595d14 into arduino:ide-1.5.x Jan 9, 2014
@matthijskooijman
Copy link
Collaborator

Ah, right. I agree that factoring out this stuff would make sense.

@cmaglie cmaglie deleted the platform-paths branch January 9, 2014 12:30
Lauszus added a commit to TKJElectronics/Balanduino that referenced this pull request Feb 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants