Implemented setClock for the Due as well #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to change the I2C clock frequency
|
Commit looks good to me (but I also don't have a Due, nor any real knowledge about the sam code). |
|
It looks that with your implementation setClock(...) must be called before begin(), any subsequent call has no effect. I fixed this with an additional patch 75ec6a1 Thank you very much! |
|
Yes you are correct. You are welcome ;) |
ollie1400
pushed a commit
to ollie1400/Arduino
that referenced
this pull request
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to change the I2C clock frequency
This is similar to my other pull request for AVR: #1912.
Note that this is NOT tested, as I do not have a Due to actually test it with.