9-bit frame support for HardwareSerial 1.5.X

[Bouni]

I've added support for sending and receiving 9-bit frames for AVR as well as SAM based boards.
The changes are tested with a test sketch [1] and also with a logic analyzer (Saleae Logic 8).

On AVR based boards i use two bytes in the buffer for storing a 9 bit frame. So i don't have to change the buffer type to uint16_t which means that all other modes then 9 bit don't waste RAM. The only downside for 9 bit users is that the buffer has only half the size.

[1] Test Sketch

[Bouni]

@ArduinoBot build this please

[matthijskooijman]

I had a quick look over this pullrequest, but it doesn't look ready to merge yet. In particular:

• There are quite some changes unrelated to the change at hand (error messages, indentation) that are not needed or at least should go into separate commits.
• It seems that some of these changes essentially re-introduce code from the master branch? I suspect you developed for master and then ported things over? It's probably best to focus on the 1.5.x branch though, I doubt that an invasive change like this will be merged into master anymore.

[Bouni]

I will take a look at the points you mentioned as soon as i can.

Thanks for the feedback!

Am 10.09.2014 12:09, schrieb Matthijs Kooijman:

I had a quick look over this pullrequest, but it doesn't look ready to
merge yet. In particular:

• There are quite some changes unrelated to the change at hand
  (error messages, indentation) that are not needed or at least should
  go into separate commits.
• It seems that some of these changes essentially re-introduce code
  from the master branch? I suspect you developed for master and then
  ported things over? It's probably best to focus on the 1.5.x branch
  though, I doubt that an invasive change like this will be merged into
  master anymore.

Reply to this email directly or view it on GitHub [1].

Links:

[1] #2291 (comment)

[Bouni]

@matthijskooijman Would you be so kind and take another look at my changes. I compared the files i've modified with the latest versions of the ide-1.5.x branch and fixed them accordingly.
Hope that it is ok now.

[ArduinoBot]

Can one of the admins verify this patch?

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[Bouni]

I'll close this as 7 years have gone by, so I guess nobody cares about this anymore 🤷🏽