Skip to content

[AVR] Fixed USB_SendControl for buffer size > 64 #4325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Dec 21, 2015

This is the best implementation I've got so far, this add 52 bytes (of ~3900 total) to the empty sketch.

I have not tested with transfers > 64 bytes, @NicoHood may you give it a try?

related to #4317
/cc @facchinm

@cmaglie cmaglie added feature request A request to make an enhancement (not a bug fix) Type: Bug Architecture: AVR Applies only to the AVR microcontrollers (Uno, etc.) Component: USB Device Opposed to USB Host. Related to the USB subsystem (SerialUSB, HID, ...) labels Dec 21, 2015
@cmaglie cmaglie self-assigned this Dec 21, 2015
@cmaglie cmaglie added this to the Release 1.6.8 milestone Dec 21, 2015
@NicoHood
Copy link
Contributor

This was my fix:
NicoHood@71c88b6

You might want to check if my version gives the same overhead.

@facchinm rejected it cause of the overhead. That's why I added the Long function, because I need the 64 byte fix. From theory it should work, but I cannot test right now.

@cmaglie
Copy link
Member Author

cmaglie commented Dec 23, 2015

hi @NicoHood

I remember that @facchinm has discussed this one briefly with me, probably at the time I didn't understood the relevance of this patch, so sorry to take so long to make up our mind!

I checked your patch it seems to be the best until now:

patch empty sketch size delta
no patch 3916 0
NicoHood@71c88b6 3966 +50
cmaglie@de5a139 3968 +52

So, I'm going to use you patch at NicoHood@71c88b6

thanks!

@cmaglie cmaglie closed this in d893aa0 Dec 23, 2015
@cmaglie cmaglie deleted the fix-usb-sendcontrol branch December 23, 2015 14:36
@NicoHood
Copy link
Contributor

You might want to rename the variables, the names are horrible tbh by myself. But yeah, thx for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture: AVR Applies only to the AVR microcontrollers (Uno, etc.) Component: USB Device Opposed to USB Host. Related to the USB subsystem (SerialUSB, HID, ...) feature request A request to make an enhancement (not a bug fix) Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants