Skip to content

Catch and report errors parsing contributed index files #4692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sandeepmistry
Copy link
Contributor

Resolved #4686.

cc/ @facchinm

@sandeepmistry sandeepmistry added the Component: IDE The Arduino IDE label Mar 14, 2016
@per1234
Copy link
Collaborator

per1234 commented Mar 15, 2016

I gave it a test with https://gist.githubusercontent.com/per1234/78bd7854b839dd71a567/raw/022b2fcc1b7f721f04623758c6fd9b5b4302e685/package_per1234_test_index.json which is missing the last closing bracket. This file causes the hourly build to no longer load once it has been downloaded but is handled correctly by the build in this PR. Thanks sandeepmistry!

@facchinm
Copy link
Member

👍 perfect!

@cmaglie cmaglie merged commit 9dba7f0 into arduino:master Mar 17, 2016
@cmaglie cmaglie added this to the Release 1.6.9 milestone Mar 17, 2016
@sandeepmistry sandeepmistry deleted the contributed-index-parsing-exception branch July 18, 2016 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE The Arduino IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants