Skip to content

Disable cut and copy if there is not selected text #4790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2016

Conversation

ar-vargas
Copy link
Contributor

Fix for #4789

}

@Override
public void menuDeselected(MenuEvent e) {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you Overriding this?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it because MenuListener implements an interface?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Because I'm instancing an anonymous class from MenuListener, it's mandatory to implement every method. But I choose use only menuSelected for checking if there's selected text.

@CarlosMiguelCuevas
Copy link

LGTM

@ivanebernal
Copy link
Contributor

LGTM!

@cmaglie cmaglie added feature request A request to make an enhancement (not a bug fix) Component: IDE user interface The Arduino IDE's user interface labels Apr 6, 2016
@cmaglie cmaglie merged commit baa8a6e into arduino:master Apr 6, 2016
@cmaglie cmaglie added this to the Release 1.6.9 milestone Apr 6, 2016
@cmaglie
Copy link
Member

cmaglie commented Apr 6, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE user interface The Arduino IDE's user interface feature request A request to make an enhancement (not a bug fix)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants