Skip to content

Filter examples based on contributed libraries by architecture #4828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2016

Conversation

facchinm
Copy link
Member

@facchinm facchinm commented Apr 6, 2016

Adds "COMPATIBLE" filter for Contributed libraries, this is not enough to ensure that the correct examples get displayed because the addOrReplace routine overrides the previous results.
Adding an architecture-aware routine to handle this (overrides old library only if the the architecture field is compatible)

Solves #4762, to be tested with nightly (arduino-builder >= 1.3.15)

@sandeepmistry
Copy link
Contributor

@facchinm this looks good on OS X.

When I select a SAMD core board, the following examples are visible for the USBHost library:

  • ADKTerminalTest
  • KeyboardController
  • MouseController
  • USB_desc

and for SAM:

  • ADKTerminalTest
  • KeyboardController
  • MouseController

Which lines up with:

sandeepmistry added a commit to sandeepmistry/Arduino that referenced this pull request Jul 19, 2016
Filter examples based on contributed libraries by architecture
@sandeepmistry sandeepmistry merged commit c28c854 into arduino:master Jul 19, 2016
@sandeepmistry sandeepmistry added the Component: IDE The Arduino IDE label Jul 19, 2016
@sandeepmistry sandeepmistry added this to the Release 1.6.10 milestone Jul 19, 2016
@facchinm facchinm deleted the issue_4762 branch January 4, 2017 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE The Arduino IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants