Implement Do-Not-Verify-After-Upload preference for Serial Uploads #4873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change picks up the existing upload.verify preference from the preferences dialog/preferences.txt and allows you to use this with your USB/Serial upload tool of choice. Configuration is already added for avrdude. This option stopped working somewhere around the update to 1.5.
It uses PreferencesMap.get to avoid an exception if the config is not found in platforms.txt - this should avoid problems with other cores and allow backwards compatibility.
The SAM and SAMD cores can be updated later if required. They won't benefit much from the change as the upload speed is so much better.