-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Move Caterina_BL related defines into generic USBCore.h #4967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In an excess of confidence, these defines were added to Leonardo's variant.h 3rd party boards sometimes avoid inheriting this variant but they still define USBCON, thus breaking the build
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4967-BUILD-553-linux32.tar.xz ℹ️ The |
Will this fix NicoHood/HoodLoader2#28 ? |
Yes, this should fix it. |
I am getting this error with the MediaTek 7688 BSP and tried everything including nightly builds: C:\Users\kenneth_coley\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.6.11\cores\arduino\CDC.cpp: In function 'bool CDC_Setup(USBSetup&)': C:\Users\kenneth_coley\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.6.11\cores\arduino\CDC.cpp:104:29: error: 'MAGIC_KEY_POS' was not declared in this scope
C:\Users\kenneth_coley\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.6.11\cores\arduino\CDC.cpp:129:34: error: 'MAGIC_KEY' was not declared in this scope
exit status 1 Error compiling for board LinkIt Smart 7688 Duo.The above links do not work. |
@konakcc , you are using the nighly build of the IDE but the compiled core is still avr 1.6.11 release (since it lives in |
Thanks, I was able to make it work by downgrading the AVR to 1.6.10 |
Downgrading the AVR to 1.6.10 worked. |
In an excess of confidence, these defines were added to Leonardo's variant.h
3rd party boards sometimes avoid inheriting this variant but they still define
USBCON
, thus breaking the build@NicoHood