Skip to content

Properly escape avrdude.upload.network_pattern to handle spaces in path #5753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Properly escape avrdude.upload.network_pattern to handle spaces in path #5753

wants to merge 1 commit into from

Conversation

facchinm
Copy link
Member

No description provided.

@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5753-BUILD-627-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5753-BUILD-627-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5753-BUILD-627-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5753-BUILD-627-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5753-BUILD-627-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

matthijskooijman
matthijskooijman reviewed Dec 24, 2016
View reviewed changes
hardware/arduino/avr/platform.txt
build.usb_flags=-DUSB_VID={build.vid} -DUSB_PID={build.pid} '-DUSB_MANUFACTURER={build.usb_manufacturer}' '-DUSB_PRODUCT={build.usb_product}'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see what changed in this line (and the commit message doesn't talk about it either)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a whitespace added at the end of the file

@cmaglie
Copy link
Member

cmaglie commented Dec 28, 2016

Rebased and merged (and removed the extra whitespace)

@cmaglie cmaglie closed this Dec 28, 2016
@cmaglie cmaglie added this to the Release 1.8.1 milestone Dec 28, 2016
@facchinm facchinm deleted the arduinoota-spaces-path branch January 4, 2017 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthijskooijman matthijskooijman matthijskooijman left review comments

@cmaglie cmaglie cmaglie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.8.1
Development

Successfully merging this pull request may close these issues.
4 participants
@facchinm @ArduinoBot @cmaglie @matthijskooijman