Skip to content

Issue #5849: Added clear button to serial monitor UI #6092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Issue #5849: Added clear button to serial monitor UI #6092

wants to merge 2 commits into from

Conversation

rlaferla
Copy link

@mastrolinux mastrolinux added the in progress Work on this item is in progress label Mar 18, 2017
matthijskooijman
matthijskooijman approved these changes Mar 19, 2017
View reviewed changes
Copy link
Collaborator

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Just one thing: I think this should be just a single commit, the first one isn't really independently useful IMHO.

@facchinm facchinm added this to the Release 1.8.3 milestone Mar 20, 2017
@FernandoGarcia
Copy link

@facchinm It's duplicated from #5921?

@facchinm
Copy link
Member

@FernandoGarcia , correct, it's indeed a duplicate. I added both on the next milestone so we can compare them and avoid losing some code

@cmaglie
Copy link
Member

cmaglie commented Apr 10, 2017

Fixed by 99006fc that is almost the same implementation, excecpt for the button that is in the right lower corner.

@cmaglie cmaglie closed this Apr 10, 2017
@mastrolinux mastrolinux removed the in progress Work on this item is in progress label Apr 10, 2017
@per1234 per1234 added Component: IDE Serial monitor Tools > Serial Monitor feature request A request to make an enhancement (not a bug fix) Type: Duplicate Another item already exists for this topic labels Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthijskooijman matthijskooijman matthijskooijman approved these changes

Assignees
No one assigned
Labels
Component: IDE Serial monitor Tools > Serial Monitor feature request A request to make an enhancement (not a bug fix) Type: Duplicate Another item already exists for this topic
Projects
None yet
Milestone
Release 1.8.3
Development

Successfully merging this pull request may close these issues.
7 participants
@rlaferla @FernandoGarcia @facchinm @cmaglie @matthijskooijman @mastrolinux @per1234