Skip to content

Added delete operators to comply with new gcc [C++17] #7157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kpochwala
Copy link

Earlier, when compiled with -fsized-deallocation warning enabled, this file caused problems. I also added noexcept specifier. Now it compiles with gcc 7.2 and -std=gnu++17 without problems.

@matthijskooijman
Copy link
Collaborator

Is noexcept needed? We're always running with -fno-exceptions, so noexcept might not be needed, or even wrong (not sure)? There is some previous discussion on a related subject in #108.

Can you be a bit more explicit about what problems you were running in without this delete operator? Is this operator new in C++17, or is there something in C++17 that makes it needed while it was not before?

@facchinm facchinm added the c++14 Related to switching to use of the C++14 standard label Jan 26, 2018
@facchinm
Copy link
Member

Hi @kpochwala ,
we are closing all the hardware related PRs in this repo.
If you are still interesting in getting this merged could you reopen in https://github.com/arduino/ArduinoCore-avr ? Here you can find some hints about reapplying the patch to that repo easily.
Thanks!

@facchinm facchinm closed this Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++14 Related to switching to use of the C++14 standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants