Use user-defined tab settings in new sketch generation #8686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@facchinm @cmaglie When making this change, I were left with two questions:
|
|
Apache commons was introduced as a dependency very late, so that's the reason for code duplication. Using commons everywhere would be a good solution IMO. In parallel it would be awesome to make the whole codebase consistent again (I'm sure there are at least 3 methods to write a string to a file in use right now 🙂 ) Anyway, I really like this PR! We are currently having a small problem on the download server so I can't launch the ArduinoBot build on it but I'll do as soon as we fix it. |
facchinm
added
the
feature request
When creating a new sketch, it is initialized with the BareMinimum example sketch. This example sketch uses 2-width whitespace indentation, which might differ from the user-defined tab settings. This commit makes the generated example sketch consistent with the user-defined tab settings.
Pieter12345
force-pushed
the
new-sketch-indentation-consistency
branch
from
03d88ee to
f3e787e
Compare
|
Rebased this PR onto master. |
pfeerick
reviewed
Jun 23, 2019
| @@ -764,7 +764,20 @@ protected File createNewUntitled() throws IOException { | |||
| if (!newbieFile.createNewFile()) { | |||
| throw new IOException(); | |||
| } | |||
| FileUtils.copyFile(new File(getContentFile("examples"), "01.Basics" + File.separator + "BareMinimum" + File.separator + "BareMinimum.ino"), newbieFile); | |||
|
|
|||
| // Initialize the pde file with the BareMinimum sketch. | |||
There was a problem hiding this comment.
We're still talking about pde files? That's so last year! 😆 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new sketch, it is initialized with the BareMinimum example sketch. This example sketch uses 2-width whitespace indentation, which might differ from the user-defined tab settings. This PR makes the generated example sketch consistent with the user-defined tab settings.